Makefile migration: make build_sdk
#631
Conversation
i-am-tom
added
the
impact/no-changelog-required
|
Did you see https://docs.google.com/document/d/1ftBuHGGb7SErE2WCB-MHbOMVu_VmbF81lxS3e520e3c/edit?tab=t.0#heading=h.u981p2fv4khv? We should probably follow that, or have some more discussion there, so we can have a standard set of makefile targets. |
i-am-tom
changed the title
Makefile migration: make build-sdkMakefile migration: make build_sdk
Makefile
Outdated
| build: clean build_sdk build_language_host | ||
|
|
||
| build_sdk: | ||
| cd sdk && dotnet restore --no-cache |
There was a problem hiding this comment.
I see this is what we already do without much of an explanation, but I'm curious why this is needed?
There was a problem hiding this comment.
https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-restore
In most cases, you don't need to explicitly use the dotnet restore command, since if a NuGet restore is necessary, the following commands run it implicitly:
...
dotnet build
...
Good point - I think we can probably just remove this!
Co-authored-by: Thomas Gummerer <t.gummerer@gmail.com>
|
(removed from queue for readme updates) |
Following on from #629, this PR lifts
buildSdkinto theMakefile.make buildnow runsbuild_sdk(migrated from the F# file) andbuild_language_host(previouslymake build).